check the server's HTTP/3 SETTINGS before initiating a session #120
+128
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
commented
Mar 9, 2024
| DontCloseRequestStream: true, | ||
| CheckSettings: func(settings http3.Settings) error { | ||
| if !settings.EnableExtendedConnect { | ||
| return errors.New("server didn't enable Extended CONNECT") |
There was a problem hiding this comment.
Note that this check will break compatibility with older and the current version of webtransport-go, since quic-go servers only start enabling Extended CONNECT starting with the next release.
marten-seemann
force-pushed
the
update-quic-go-v042
branch
from
a1fabea
to
2a78f5c
Compare
marten-seemann
force-pushed
the
client-check-server-settings
branch
from
98bffd5
to
065a100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109. Depends on quic-go/quic-go#4355.